LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
594 stars 37 forks source link

Feature request: ability to control water colour from the config #1532

Open aredfan opened 2 months ago

aredfan commented 2 months ago

This is to log what was discussed on discord, and in some ways mirrors #634.

The level builders have control over water colour in the gameflow on a per-level basis, and this arrangement will continue to have priority over the config when using a mod. However, the default water colour for all levels could be moved to config, with a drop-down selection of 3 options: TombATI, PS1 and DOS water colours.


Config options R G B
TombATI 0.45 1.0 1.0
PS1 0.3 1.0 1.0
DOS 0.6 0.7 1.0

For reference: https://github.com/LostArtefacts/TR1X/blob/develop/GAMEFLOW.md#global-properties

Richard-L commented 2 months ago

Thanks for this.

Can I ask where you have the PS1 values from? 👀 I always thought they were the same as TombATI.

I think in theory there are even more water colours, and I remembered saving this image from Discord in 2021, posted by a member called "k1nomoto". Its validity is a little questionable to me though, given as some just seem darker than others (?). Still wanted to share.

unknown

Worthy of note for me is that supposedly the PowerVR version has code for water cloudiness, like Saturn: #145

Personally, I think it would likely be fine to stick to the three options and not bloat it too much, given as I don't think we have further values, anyway. The transparent look of the software renderer could be something to consider perhaps. I imagine with something like fog added, it could look quite interesting.

aredfan commented 2 months ago

Can I ask where you have the PS1 values from? 👀 I always thought they were the same as TombATI.

Written in tombati.ini which is shipped with TombATI:

The default values 0.3 and 1.0 approximate the turquoise colors of the PlayStation version.