console: move ui to libtrx

LostArtefacts / TRX

Open source re-implementation of Tomb Raider 1 (1996), along with additional enhancements and bugfixes

https://lostartefacts.dev/

GNU General Public License v3.0

583 stars 36 forks source link

console: move ui to libtrx #1541

Closed rr- closed 6 days ago

rr- commented 1 week ago

Checklist

[x] I have read the coding conventions
[x] I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

https://github.com/LostArtefacts/libtrx/pull/37

aredfan commented 1 week ago

The prior issues are now resolved, thank you. I've noticed a small issue - the blinking caret is slower now.

lahm86 commented 1 week ago

I have text scale set at 0.8, and the console shows here. It moves further up the lower the value and can go off-screen if too high.

rr- commented 1 week ago

Fixed, but I can't say I like my solution. @lahm86 could you please take a look around the code, especially libtrx, and LMK if you see anything that I could've done better?

rr- commented 1 week ago

Fixed, but I can't say I like my solution. @lahm86 could you please take a look around the code, especially libtrx, and LMK if you see anything that I could've done better?

I've improved the APIs a bit and I'm a bit happier. There are still some design smells such as UI having to be initialized after the config or else reacting to text scaling changes will not work, or the config change events being fired by Config_Write calls, but I was unable to come up with a reasonable alternative. The widgets, especially the stack, should be in a good spot now, though.