LostArtefacts / TRX

Open source re-implementation of Tomb Raider 1 (1996), along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
583 stars 36 forks source link

TRX merger #1553

Closed rr- closed 11 hours ago

rr- commented 1 day ago

Checklist

Description

Merges TRX and libtrx into a single repository. Doesn't preserve the commit history, which we regarded as an acceptable loss.

Remaining to be done after the merge:

rr- commented 11 hours ago

Looks great and works great! Amazing. I just had to delete my old Docker containers and run a just clean.

Only minor things I noticed:

  1. just alone only builds TR1X. I guess that's an ok default to have?

Thanks, changed this to also build TR2.

  1. docs/tr1/CONTRIBUTING.md and docs/tr2/CONTRIBUTING.md should probably be slightly updated to explicitly mention just-tr1-... and just-tr2-....

Actually these two documents got merged to docs/CONTRIBUTING.md since they were mostly identical.

  1. I don't fully understand how just lint etc work now. Does the command lint both TR1X and TR2X? The CONTRIBUTING.md could also maybe reflect this answer too.

Correct – it formats all the code. Similarly autogenerated code is updated on each pre-commit trigger.