Closed rr- closed 11 hours ago
Looks great and works great! Amazing. I just had to delete my old Docker containers and run a
just clean
.Only minor things I noticed:
just
alone only builds TR1X. I guess that's an ok default to have?
Thanks, changed this to also build TR2.
docs/tr1/CONTRIBUTING.md
anddocs/tr2/CONTRIBUTING.md
should probably be slightly updated to explicitly mentionjust-tr1-...
andjust-tr2-...
.
Actually these two documents got merged to docs/CONTRIBUTING.md
since they were mostly identical.
- I don't fully understand how
just lint
etc work now. Does the command lint both TR1X and TR2X? TheCONTRIBUTING.md
could also maybe reflect this answer too.
Correct – it formats all the code. Similarly autogenerated code is updated on each pre-commit trigger.
Checklist
Description
Merges TRX and libtrx into a single repository. Doesn't preserve the commit history, which we regarded as an acceptable loss.
Remaining to be done after the merge: