LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
586 stars 38 forks source link

OG bug: Various issues when Z Buffer is enabled #1595

Open aredfan opened 6 months ago

aredfan commented 6 months ago

Dropped flares end up beneath the surface

https://github.com/LostArtefacts/TRX/assets/94776985/b93072b4-d61f-4fc2-9c11-b79f0a76b8fe


Water animated texture is visible on the interior floor of the boat

https://github.com/LostArtefacts/TRX/assets/94776985/752436c1-23fa-4eff-9a69-66e6d5811299


Some disc sparks are not visible

https://github.com/LostArtefacts/TRX/assets/94776985/4275ccab-7917-455e-a52c-4d4292ead2df


Wall light fixture have z-fighting with the wall

https://github.com/LostArtefacts/TRX/assets/94776985/0e5f3a20-3be0-4fca-ad72-b7395eef59fb


1

rr- commented 5 months ago

What sense is there to disable the z-buffer?

aredfan commented 5 months ago

What sense is there to disable the z-buffer?

I would say that it's preferable to keep z-buffer enabled even though it causes a few issues. Without z-buffer, we'll have textures clipping and objects appearing through walls.

https://github.com/LostArtefacts/TR2X/assets/94776985/848abf7e-e22c-4f10-be29-d773c5d1296d

rr- commented 5 months ago

That's what I mean – IMO it should always be enabled; can you list the issues that come with enabling the z-buffer?

aredfan commented 5 months ago

That's what I mean – IMO it should always be enabled; can you list the issues that come with enabling the z-buffer?

Yes, of course. 👍

These are the issues I know of when z-buffer is enabled, but I'll make sure to add to the list if I see anything else.

rr- commented 5 months ago

That's so weird! I thought it was about having it disabled. Wow.

Richard-L commented 5 months ago

My hunch is this list will potentially be quite long.

Why is it not as much an issue in TR1?