LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
588 stars 38 forks source link

OG bug: fix Bartoli sunset timer #1617

Open Richard-L opened 1 year ago

Richard-L commented 1 year ago

In addition to the sky texture changing in Bartoli https://github.com/LostArtefacts/TRX/issues/1618, the overall brightness of the level changes. Apparently this happens even on OG PC TR2 too, as shown in this clip by Troye: https://github.com/user-attachments/assets/952be157-193e-4195-baf5-edc5d60e6f2b

Arsunt had found that this happens over a period of 20mins. However, Core apparently messed up the timer:

Core made this feature. But they did not sync it with level timer They made separate frame counter, which was reset every time when you load game So if you load game, you need to wait another 20 minutes It's so stupid I just check the timer in statistics menu It always ticks from level start. Not level load

He then enhanced the feature in TR2Main to darken the skybox too:

By the way, I made sky darker with sunset for Bartoli's Hideout. Here is how it looks now. Here is the day (start of the level). image And here is the sunset. 20 minutes passed. In the original game sky keeps brightness unchanged. image

aredfan commented 1 year ago

I was considering adding a request for this yesterday, regardless, thank you for doing so in a detailed way 👍

Just to add this extra piece of information:

For that I plan to add metadata in the end of savefile. A slightly larger savefile will still be compatible with the original game, but the TR2Main will be able to read additional data, such as a music track position (started by a trigger before game is saved), or a sunset state.

Source