search

LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
594 stars 37 forks source link

Implement 3D pickups #1838

Closed rr- closed 2 weeks ago

rr- commented 2 weeks ago

Checklist

Description

Resolves #1634.

github-actions[bot] commented 2 weeks ago

Download the built assets for this pull request:

rr- commented 2 weeks ago

Really nice 🎉

Just two things:

  • Items rotate to Lara's rotation when she picks them up (for position testing). I believe this was addressed in TR1 by having a cleanup to reset the item's position again before leaving the function. It's in TR1's Pickup_Collision; in TR2 it's in M_DoAboveWater and M_DoUnderwater in pickup.c.

Fixed

  • Could we add the option to the config tool? I think it'll just need the equivalent from TR1 directly copied.

Added

Thanks.

aredfan commented 2 weeks ago

I found this one issue - the Talion pickup is half buried in the surface of Ice Palace.

1

rr- commented 2 weeks ago

@aredfan addressed, its position is better now, and the prayer wheels are happy as well. Sadly, this means it'll require rechecking everything from scratch.

CC @lahm86 @walkawayy

aredfan commented 2 weeks ago

The Talion is fixed. I've checked all of Lara's essentials and most keys/puzzles. The following items are buried partially.

rr- commented 2 weeks ago

@aredfan just added another fix (courtesy of Lahm). To make our lives easier I've also added the ability to repeatedly issue /tp pickup so that it'll cycle through all level pickups in round-robin fashion (will work for /tp in TR1 as well). Remember that we can now also cycle through command history with the up/down arrows, which makes it extra comfy.

Richard-L commented 2 weeks ago

I really regret I can't be more involved with testing these days as work is just busy, but I am following along and marvel at you guys' progress every day ❤️

This looks amazing.