search

LostArtefacts / TRX

Open source re-implementation of Tomb Raider I and Tomb Raider II, along with additional enhancements and bugfixes
https://lostartefacts.dev/
GNU General Public License v3.0
588 stars 38 forks source link

TR2X bug: visible overlap of rooms in The Deck #1853

Open aredfan opened 1 day ago

aredfan commented 1 day ago

Regression since: 0.6

Steps to reproduce:

  1. /play 10
  2. /tp 51 4 48
  3. move the camera until you can see the rooms overlapping

20241108_195122_The_Deck

lahm86 commented 1 day ago

This is a strange one. It seems like a data issue - room 17 has a visibility portal into room 104 (which is clearly wrong, must have been a level editing bug), and in turn because that is linked to room 80, room 80 is drawn. The portal is marked by the waypoints here, just imagine it pointing downwards to room 104.

image

I'm not sure where the regression is if this doesn't happen in OG. Ideally we would fix the data and the regression itself.

aredfan commented 15 hours ago

Thanks for providing a detailed breakdown there Lahm.

Btw this issue also manifests in the upper end of the level where Lara picks up the last key.

20241109_072217_The_Deck

lahm86 commented 12 hours ago

This seems to have been caused by https://github.com/LostArtefacts/TRX/commit/6c365499e529de0c0f0cf2ab152515a82f91881b. Restoring the various g_FltWinLeft = g_PhdWinMinX; //...etc calls in output.c that were removed in that commit fixes it, but there are side effects:

image