search

LostConnection / makeitdark

Python tool to inject a dark theme into the Slack desktop application
MIT License
74 stars 103 forks source link

Bash version of script #9

Open kakposoe opened 5 years ago

kakposoe commented 5 years ago

I have used the python script and everything worked fine and smoothly. However, as a dependancy a user of this script will need to install python (I already had this so it's not an issue for me).

It would be good to provide both python and bash versions for those who don't have python and have no need for it after the makeitdark install.

LostConnection commented 5 years ago

Good point, I can write some bash script but it will most likely be a very simple text appending script and will most likely not support windows because of the dynamic installation path.

Piees commented 5 years ago

Personally I'd assume packaging it into an executable would have a similar effect of not needing the dependency, however it wouldn't be as agnostic as bash script. Could however adding packaged versions in a dist folder be helpful?

ammmze commented 5 years ago

I've got a bash script for this in my own project I threw together for the devs at my company. https://github.com/MashupMill/slack-themes/blob/master/install.sh

It works relatively similar to your python script using markers to mark out the start and end, so you can strip it out.

You could probably strip out the dev mode stuff. I use that when I'm testing CSS changes. It just spins up a little http server (via nodejs) serving up my local CSS files.