LostInBrittany / granite-qrcode-scanner

A webcomponent to scan a QR Code
MIT License
22 stars 7 forks source link

debug #18

Open davidmaxwaterman opened 5 years ago

davidmaxwaterman commented 5 years ago

There's a lot of debug noise, I think due to:

https://github.com/LostInBrittany/granite-qrcode-scanner/blob/master/granite-qrcode-scanner.js#L179

              debug="${this.debug}"></granite-app-media-periodic-image-capture>

which I think should be:

              ?debug="${this.debug}"></granite-app-media-periodic-image-capture>

or perhaps .debug="${this.debug}".

LostInBrittany commented 5 years ago

Oups, sorry about that, going to fix...

On Wed, Sep 11, 2019 at 9:14 AM Max Waterman notifications@github.com wrote:

There's a lot of debug noise, I think due to:

https://github.com/LostInBrittany/granite-qrcode-scanner/blob/master/granite-qrcode-scanner.js#L179

          debug="${this.debug}"></granite-app-media-periodic-image-capture>

which I think should be:

          ?debug="${this.debug}"></granite-app-media-periodic-image-capture>

or perhaps .debug="${this.debug}".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LostInBrittany/granite-qrcode-scanner/issues/18?email_source=notifications&email_token=AAFRLTDVMLEMUG7V44RPODTQJCLEVA5CNFSM4IVQFH62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKUHKWA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFRLTHO7ERGKUWBIBMY4ALQJCLEVANCNFSM4IVQFH6Q .