Closed lee-b closed 1 year ago
What is the error? I don't see anything failing to build from your log. Can you pull latest and try again?
There is no error, the Makefile appears to not build the correct things on that branch.
I have tried multiple times with clean checkouts, and even switched to a new PC and tried again, only to find that the main branch is fine, and the problem is that this branch is the default.
Reproduction attached. To reproduce it (as long as you have docker installed and working, bash, and unzip):
unzip koboldcpp-build-error.zip
cd koboldcpp-build-error
./test.sh
output:
...
ERROR: build problem is (still?) present
For contrast, toggle these lines in Dockerfile
:
# Uncomment the following to break it
RUN git checkout b8fe4bd
# Uncomment the following to make it work
#RUN git checkout 7b88584
to:
# Uncomment the following to break it
#RUN git checkout b8fe4bd
# Uncomment the following to make it work
RUN git checkout 7b88584
then run ./test.sh
again. Output:
...
OK, it works now.
NOTE: I'm using specific git commits here so that this continues to show the issue even if new commits occur which fix it in the repo, but the commit id that's breaking in this reproduction is the current HEAD commit on the Concedo branch.
The master branch is not used, that one is originally created during the fork and used to pull upstream changes.
So even when running make with no flags, the koboldcpp.so is not generated?
The commit hash you mentioned is over 2 months ago - also occurs before I even start development of koboldcpp
Are you running the koboldcpp.py script? What error does the python script show when it loads the koboldcpp.so file?
My bad, I was not doing that. Should have read the instructions more closely.
Prerequisites
Please answer the following questions for yourself before submitting an issue.
Expected Behavior
The default branch should build on linux, per the documentation. Would suggest switching the default branch back to master until Concedo is fixed.
Current Behavior
Default branch fails to build ./main, and instead builds kobold.so etc.
Environment and Context
Native ubuntu 23.04, x86-64.
Failure Information (for bugs)
Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.
Steps to Reproduce
Clone the repo on Linux, cd, run
make
, per the Linux instructions.Failure Logs
build.log