[User] Concedo branch doesn't build main on Linux

[lee-b]

Prerequisites

Please answer the following questions for yourself before submitting an issue.

• [x] I am running the latest code. Development is very rapid so there are no tagged versions as of now.
• [x] I carefully followed the README.md.
• [x] I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
• [x] I reviewed the Discussions, and have a new bug or useful enhancement to share.

Expected Behavior

The default branch should build on linux, per the documentation. Would suggest switching the default branch back to master until Concedo is fixed.

Current Behavior

Default branch fails to build ./main, and instead builds kobold.so etc.

Environment and Context

Native ubuntu 23.04, x86-64.

$ lscpu
...
Model name:                      AMD Ryzen 9 7950X 16-Core Processor
...

• Operating System, e.g. for Linux:

Linux (hostname withheld) 6.2.0-20-generic #20-Ubuntu SMP PREEMPT_DYNAMIC Thu Apr  6 07:48:48 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

• SDK version, e.g. for Linux:

$ python3 --version
Python 3.11.2
$ make --version
GNU Make 4.3
...
$ g++ --version
g++ (Ubuntu 12.2.0-17ubuntu1) 12.2.0
...

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Clone the repo on Linux, cd, run make, per the Linux instructions.

Failure Logs

build.log

[LostRuins]

What is the error? I don't see anything failing to build from your log. Can you pull latest and try again?

[lee-b]

There is no error, the Makefile appears to not build the correct things on that branch.

[lee-b]

I have tried multiple times with clean checkouts, and even switched to a new PC and tried again, only to find that the main branch is fine, and the problem is that this branch is the default.

Reproduction attached. To reproduce it (as long as you have docker installed and working, bash, and unzip):

unzip koboldcpp-build-error.zip
cd koboldcpp-build-error
./test.sh

output:

...
ERROR: build problem is (still?) present

For contrast, toggle these lines in Dockerfile:

# Uncomment the following to break it
RUN git checkout b8fe4bd

# Uncomment the following to make it work
#RUN git checkout 7b88584

to:

# Uncomment the following to break it
#RUN git checkout b8fe4bd

# Uncomment the following to make it work
RUN git checkout 7b88584

then run ./test.sh again. Output:

...
OK, it works now.

koboldcpp-build-error.zip

NOTE: I'm using specific git commits here so that this continues to show the issue even if new commits occur which fix it in the repo, but the commit id that's breaking in this reproduction is the current HEAD commit on the Concedo branch.

[LostRuins]

The master branch is not used, that one is originally created during the fork and used to pull upstream changes.

So even when running make with no flags, the koboldcpp.so is not generated?

The commit hash you mentioned is over 2 months ago - also occurs before I even start development of koboldcpp

[LostRuins]

Are you running the koboldcpp.py script? What error does the python script show when it loads the koboldcpp.so file?

[lee-b]

My bad, I was not doing that. Should have read the instructions more closely.