search

LostRuins / koboldcpp

A simple one-file way to run various GGML and GGUF models with KoboldAI's UI
https://github.com/lostruins/koboldcpp
GNU Affero General Public License v3.0
4.35k stars 312 forks source link

Chat mode mistakes certain texts as character names #867

Open aaronshenhao opened 1 month ago

aaronshenhao commented 1 month ago

Example save file

saved_story.json

Description

As seen in the screenshots below, the Chat mode UI mistakenly identifies any text preceding : as the name of a character. This results some odd formatting bugs.

Proposed fix

Restrict character highlighting to added characters (in localsettings.chatopponent). I've actually patched the relevant code, but I need to know, will this affect any users? Do people write other characters manually, or have characters not on the list?

Screenshot of the problem

image image

aaronshenhao commented 1 month ago

Opened a pull request: https://github.com/LostRuins/lite.koboldai.net/pull/72

henk717 commented 1 month ago

We also have an auto mode where this would be undesirable so do make sure people have names set before using the new method.

aaronshenhao commented 1 month ago

We also have an auto mode where this would be undesirable so do make sure people have names set before using the new method.

What's an auto mode?

LostRuins commented 1 month ago

Auto mode is when you don't specify a character name at all, and the model generates names itself