LostSoulfly / MinerProxy

Ethereum Stratum Mining Proxy - Replace all Wallets with your own. Claymore/EWBF proxy. Miner Proxy.
77 stars 36 forks source link

DevFee donation issue #6

Closed samu01 closed 7 years ago

samu01 commented 7 years ago

If the pool the user is mining in uses slash for worker name, it won't work for ethermine. It makes an error when connecting: "Server error for DevFee: Invalid user provided"

LostSoulfly commented 7 years ago

Hmm. I don't quite understand. Ethermine doesn't use slashes from my experience..

samu01 commented 7 years ago

That's the problem. Ethermine uses dots. So if the pool the user mines in uses slash, it will try to use a slash for Ethermine when donating, and it will disconnect with an error.

LostSoulfly commented 7 years ago

I believe I've resolved this with a simple fix, now it just replaces the wallet altogether at the end.

Good catch 👍