Lothrazar / Cyclic

Minecraft mod written in Java
MIT License
166 stars 97 forks source link

Suggestion: Better fishing net #2266

Open koalalord9999 opened 1 year ago

koalalord9999 commented 1 year ago

Minecraft Version: 1.19.2

Forge Version: 1.19.2-forge-43.2.6

Mod Version: Cyclic-1.19.2-1.7.14

Single Player or Server: SP

Describe problem (what you were doing; what happened; what should have happened):

Suggestion: Allow the fishing net to take into account enchants on the fishing rod. I got a unbreaking VIII from a master fisherman villager, and it consumes one durability 100% of the time. This should also take into account for luck of the sea, mending, lure (lowering the tick range by 2 between attempts capping out at 10 ticks, any further lure than V, increase the chance of a successful catch by 10%)

osirisgothra commented 1 year ago

Playing on FTB Skies, and yes, the unbreaking enchant does not seem to work. I ended up wasting 2 good fishing rods to find out a plain one works just the same. I didn't try normal unbreaking, but imagine it would be the same. I wonder if maybe it just isn't implemented yet since things have obviously had to be rewritten for newer versions of the modding platform. Maybe just do unbreaking at least until others are added later but seeing as most folks end up getting rods from villagers with Unbreaking VIII from modern mod packs, it kinda defeats the purpose of having the net in the first place.

In those cases I suppose it is easy enough to automate it--however early game, we aren't usually automating yet because of lack of resources, and that is the time when we get loot from villagers and whatnot. Can't imagine it would be really OP--manual fishing is an old been-there-done-that-in-vanilla thing that really should allow for this improvement for the same reason that sieves in 1.12 had luck of the sea enchants.

I am guessing this is just a result of the new platform being very different, forcing authors to have to rewrite and find new ways to do stuff because the platform is far changed.