search

Lothrazar / Cyclic

Minecraft mod written in Java
MIT License
155 stars 94 forks source link

Crash with Terralith 2.4.7 + possibly other mods #2332

Open Apollounknowndev opened 8 months ago

Apollounknowndev commented 8 months ago

Minecraft Version: 1.20.1 Forge Version: 47.1.3 Mod Version: 1.12.4

Single Player or Server: Singleplayer

Describe problem (what you were doing; what happened; what should have happened): Due to the setup of Cyclic's biome modifiers, if a biome is in multiple tags (such is in both the is_taiga and is_mountain tag) a flower feature can be added to multiple biomes and a crash will ensue. This occurs with Terralith as of Terralith 2.4.7.

Crash report: crash-2023-10-19_20.49.10-server.txt

hokomili commented 8 months ago

This is probably feature cycle violation https://forge.gemwire.uk/wiki/Biome_Modifiers#Best_Practices I've experienced server freezing, get blockstate crash, structure cut in half(with half of it floating above the flowers), etc. These problems persisted until I remove cyclic. Who could have thought they are caused by the legacies

Apollounknowndev commented 8 months ago

It's 100% a feature order cycle, I made a mod to fix it until the dev actually fixes it: https://modrinth.com/mod/cyclic-crash-fixer