Lothrazar / Cyclic

Minecraft mod written in Java
MIT License
155 stars 94 forks source link

Magnets (Enchant/Block) do not respect the "PreventRemoteMovement" NBT Tag #2360

Open BluSunrize opened 6 months ago

BluSunrize commented 6 months ago

Minecraft Version: 1.19.2

Forge Version: 43.2.1

Mod Version: 1.19.2-1.8.2

Single Player or Server: Both

Describe problem (what you were doing; what happened; what should have happened): Items with the Magnet enchant as well as the magnet block allow picking up Item entities that have the NBT Tag "PreventRemoteMovement" applied. This tag is (for instance) applied by Immersive Engineering's conveyor belts.

This NBT Tag on Item entities has established itself in the modding community as a global flag for "don't magnet that!" It was originally hashed out between Vazkii, Ellpeck, WayOfTime, myself and a few others. We agreed on PreventRemoteMovement. I made my conveyors apply that tag, and various devs adjusted their magnet to ignore entities tagged as such. It would be super useful if Cyclic did the same!

For example implementation see here: https://github.com/Draconic-Inc/Draconic-Evolution/blob/master/src/main/java/com/brandon3055/draconicevolution/items/tools/Magnet.java#L73-L75 https://github.com/SuperMartijn642/SimpleMagnets/blob/forge-1.19/src/main/java/com/supermartijn642/simplemagnets/MagnetItem.java#L71

Log file link: Not much to log here, I can provide a debug crash if needed, but that's not gonna help here

Video/images/gifs (direct upload or link): grafik grafik