Lothrazar / Cyclic

Minecraft mod written in Java
MIT License
155 stars 94 forks source link

too many sounds lags the client #2362

Open lennyservant opened 5 months ago

lennyservant commented 5 months ago

Minecraft Version: 1.20.1

Forge Version: 47.2.18

Mod Version: 1.12.5

Single Player or Server: Single Player (Chosen's Modded Adventure 0.6.1)

Describe problem (what you were doing; what happened; what should have happened): massive amounts of sound events drops FPS down to the point where the client is unresponsive for a few seconds, even with sounds set to 0%.

one of the ways where sound events get spammed is by pulling from a bottomless create hose pulley using an AE2 io port, which plays ~256 sounds per tick.

muting the sound by setting the sound volume to 0% normally is enough avoid the lag, but this doesn't seem to work with cyclic.

Log file link: spark profile (w/ cyclic) spark profile (w/o cyclic)

spark profile (w/ cyclic, block sounds set to 0%) spark profile (w/o cyclic, block sounds set to 0%)

Video/images/gifs (direct upload or link):

w/ cyclic:

https://github.com/Lothrazar/Cyclic/assets/45115987/7cd020c0-77e8-4698-a8d2-58b3d445467c

w/o cyclic:

https://github.com/Lothrazar/Cyclic/assets/45115987/fbe6c043-cd2a-42ea-8a94-42ed08a27d3e

w/ cyclic, block sounds set to 0%:

https://github.com/Lothrazar/Cyclic/assets/45115987/64a35b2b-fee6-48bf-892b-1c052347c61c

w/o cyclic, block sounds set to 0%:

https://github.com/Lothrazar/Cyclic/assets/45115987/598ccf58-ff72-43d1-b905-0f9ea6b49de0

Mattia98 commented 3 months ago

I've just been debugging my Minecraft for hours now, until i figured out it was Cyclic causing this issue. Just a small animal farm is enough to cause the FPS to go below 1. Turning off sound makes the FPS go back up. Removing Cyclic makes the game playable again without turning off sound.

Minecraft Version: 1.20.1 Forge Version: 47.2.0 Mod Version: 1.12.6