search

Lothrazar / DimStacker

DimStacker
MIT License
1 stars 1 forks source link

[Suggestion] adding support for JED #4

Open Silverrain2004 opened 4 years ago

Silverrain2004 commented 4 years ago

Hello Guys :)

Since there are just a few possibilitys to add custom Dim, the huge problem is..that nearly all custom Dim register their Dimension very late... so thats why you cant register custom Dimension made this way. Ofc Mods like Aroma Mining World, Beneath and so on, are possible with your Mod.. but not Custom one. --> https://github.com/JackyyTV/DimensionalEdibles/issues/20

If you Guys can make it, it would be a very good Asset for Futuretask :)

Lothrazar commented 4 years ago

Which dimensions are registering "Very Late" ? It works with Beneath as you say.

By custom ones do you mean a dimension created by RF tools? or what exactly?

Shadows-of-Fire commented 4 years ago

What support even needs to be added? DimStack doesn't resolve dimension ids until the game is running anyway

Silverrain2004 commented 4 years ago

no i just mean Mods like JED -->https://www.curseforge.com/minecraft/mc-mods/just-enough-dimensions or https://www.curseforge.com/minecraft/mc-mods/simple-dimensions ... i havent tried https://www.curseforge.com/minecraft/mc-mods/dimensional-control becouse i dont know how it works... but i guess it registers Custom Dimension in the same way........ soo @Shadows-of-Fire you say Dimstack does that? ... i havent tried with the latest Version though ... but last time i tried .. it wasnt possible... becouse i can teleport to my custom Dimension via Command.. but there is no Key and no Portal avaible for my CustomWorld ... so thats why i said.. please add Support for JED

Shadows-of-Fire commented 4 years ago

Keys exist for whatever dimensions you configure them to exist for, and dimensions are not resolved until runtime. I'm still not sure what, if any, functionality you are requesting.

Silverrain2004 commented 4 years ago

ok ... let me Test with the latest Dimstack, and JED ... and i will show you what i mean.

ICY105 commented 4 years ago

Reviving this issue because I've run into the same problem: As far as I can tell, JED registers its dimensions during run-time as the world loads, so it's past initialization. I believe the only way to support this would be to print a warning instead of throwing and error during initialization and catch the error during run-time, unless the dimension exists in which case you can teleport the player there.