Lothrazar / PlainGrinder

PlainGrinder Minecraft forge java
MIT License
0 stars 4 forks source link

Default recipes can't be removed #11

Open Warhand opened 1 year ago

Warhand commented 1 year ago

Minecraft Version: 1.18.2

Forge Version: 40.1.71

Mod Version: 1.2.4

Single Player or Server: Both

Describe problem (what you were doing; what happened; what should have happened): When trying to remove the default recipes with something like Crafttweaker or a datapack, they still remain ingame, no matter what I try to do to remove them.

This is a rather urgent issue imo, as it makes it impossible for packdevs to customize the recipes for the plain grinder, because while they can add new recipes, they can't overwrite the originals, meaning they can't add another recipe for griding raw iron without there being a conflict between which recipe the grinder will choose to base the output off of.

Log file link: https://gist.github.com/Warhand/78f45266a587c5d1cb4c2d8d7c30aa37

pjlasl commented 1 year ago

I second this enhancement.

ZAKsPop commented 1 year ago

Can't you just edit the mod directly? Just go in plaingrinder-1.18.1-1.2.4.jar\data\plaingrinder\recipes\grinder and edit the json. I hope that this is OK. But sometimes I mod the mod.

Warhand commented 1 year ago

Actually that's roughly what I did, except I paid someone else to do it for me, since I don't know JavaScript. They helped me make a fork that fixes the issue outlined in this report

On Tue, Jan 10, 2023, 10:21 PM ZAKsPop @.***> wrote:

Can't you just edit the mod directly? Just go in plaingrinder-1.18.1-1.2.4.jar\data\plaingrinder\recipes\grinder and edit the json. I hope that this is OK. But sometimes I mod the mod.

— Reply to this email directly, view it on GitHub https://github.com/Lothrazar/PlainGrinder/issues/11#issuecomment-1378193572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6I3D64P2W7G4SJC44VU53WRYRLVANCNFSM6AAAAAARNV7QFY . You are receiving this because you authored the thread.Message ID: @.***>

Gbergz commented 1 year ago

Would be lovely if they can be edited/removed, agreed with op.

Lothrazar commented 1 year ago

To disable any recipe, add the forge false condition to JSON of the recipe . For example, in the json file in the data pack replace it with

{ "conditions":[ { "type": "forge:false" } ] }

I will see if i can get some better examples or make a sample data pack

Lothrazar commented 1 year ago

i know its months later but im fixing datapacks to add/remove and adding full zenscript for craft tweaker to 1.16.5+ pretty soon