search

Lothrazar / RootsClassic

Port of Roots 1 originally by Elucent (based on latest public MIT version, with permission from EpicSquid)
MIT License
3 stars 13 forks source link

Update TabletPageScreen.java #109

Closed ErythroCraft closed 2 months ago

ErythroCraft commented 2 months ago

editing nested code block

Mrbysco commented 2 months ago

Is there any reason for these changes? Feels nit-picky

ErythroCraft commented 2 months ago

Is there any reason for these changes? Feels nit-picky

sure it is, but it's going faster

So I found many parts I'll editing

ErythroCraft commented 2 months ago

@Mrbysco END

will not edit today

TelepathicGrunt commented 2 months ago

@ErythroCraft None of your changes actually will improve performance. The code is basically going to be optimized to the same or nearly same bytecode by JIT. All I really see here is just code style changes. That's it. No change that actually reduces workload in a measurable way to the player.

However, one thing I do see is several spots changes the existing calculations due to the new parenthesis and thus, will change the behavior of this screen. Have you tested this in-game to verify that the new order of operations doesn't actually break the screen in unintended ways from past behavior?

ErythroCraft commented 2 months ago

Thank you @TelepathicGrunt. This will help creating ChatGPT for Minecraft, to creating mods simpler.