Lothrazar / RootsClassic

Port of Roots 1 originally by Elucent (based on latest public MIT version, with permission from EpicSquid)
MIT License
3 stars 13 forks source link

[1.18.1] Spells do not respect other mods' methods of detecting and preventing player damage to own pets #69

Open Not-February opened 2 years ago

Not-February commented 2 years ago

Minecraft version & Mod Version: Minecraft 1.18.1, Roots Classic 1.1.16

Single player or Server: Single player

Describe problem (what you were doing / what happened): I consider this a significant problem primarily because of mod interactions. It's uncomfortably easy to harm creatures you don't want to harm(like your pets) even if you have a mod installed that generally blocks you from damaging your own pets, for example.

I tried this with Mahou Tsukai's Geas spell active(which prevents you from damaging specified entities) as well as Enigmatic Legacy's Guide to Animal Companionship(which is meant to prevent you from dealing damage to any animals while it is in your inventory), and neither method prevented my own pets from being hurt when I used a spell near them.

Mrbysco commented 1 year ago

In 1.19 I've added entity context to the spells that can harm mobs which should give enough context for mods to cancel the attack