search

Lothrik / diablo4-build-calc

A build calculator for Diablo 4.
https://lothrik.github.io/diablo4-build-calc/
GNU Affero General Public License v3.0
218 stars 41 forks source link

Improving stats and usability #28

Open FBrebion opened 1 year ago

FBrebion commented 1 year ago

Hey, great work on this D4 build calculator, here are a few points of feedback/requests:

  1. On the paragon board stats there is often things such as "+50% non-physical damage" and "+[100-120%] non-physical damage" (Note: applies to all kind of stats here, non-physical is just an example). That makes it hard to figure out the total. I think it'd be better if the bonuses were merged (in this case: +[150-170%] non-physical damage).

  2. It would be nice if the skill tree's passive bonuses were also integrated/merged into the stats window (assuming they're permanent, and not conditioned to using a skill of course). Ex.: Permafrost on sorcerer, Golem mastery on necro, etc..

  3. Same with aspect of items, although I'm assuming that'd be a lot more work.

  4. That one is more tricky: some glyphs giving a bonus on some boards do not seem to affect the magic nodes, probably because the bonus type isn't immediately the same than the element type of the magic node. Ex.: on sorcerer's "Searing Heat" board, the "Elementalist" glyph is supposed to give up to +192% bonus for non-physical damage. The magic nodes within range aren't "+X% non-physical damage" so they aren't affected.. but they are doing "+X% fire damage", which to my understanding should be affected by this glyph's bonus, as fire damage is a part of non-physical damage.. and that means that the total stats window isn't entirely reflecting the build's strength.

  5. Can you increase the height of the glyph and board selection windows ? The glyph one in particular shows only 2 glyphs out of the whole list, forcing you to scroll all the time..

Cheers, and keep the nice work going ! :)

Lothrik commented 1 year ago

#1: I'm fairly certain what you're referring to is a parsing limitation. Blizzard frequently describes similar stats in an inconsistent manner, and beyond "exact matches" I have no real way of knowing which stats merge together. I may address this in the future, but probably not this week.

#2: This would make more sense as part of the Copy Summary button IMO.

#3: This essentially already exists, it's part of the Copy Summary button under Show Menu.

#4: Yes, I can look into that.

#5: You don't actually have to scroll at all, there is a search box. Regardless, I just pushed a change that will automatically expand those selection windows to fill the available vertical space.

FBrebion commented 1 year ago

5: Thanks that's so much better.

2 and #3: personally Copy Summary does not give me the information I want. What I'd like is tweaking my build and seeing the entire list of stats bonuses in a single window with all the total values for passives that I've achieved in this build ( paragon nodes + skill tree + items ). So all-in-1, instead of splitting the information in multiple places.

FBrebion commented 1 year ago

Another suggestion:

When you search on a keyword, in the paragon board, the node gets colored in green. That makes it hard to see if you had selected that node in your build or not. Would it be possible to display 2 squares instead (the "normal" one, with the selection color as before, and an "expanded" additional square surrounding it, showing if the node was a result of the search keyword) ?