Improve usage of Hope effects on items

LotroCompanion / lotro-companion

A graphical tool to manage your Lotro Characters (including gear/stats simulation)

32 stars 4 forks source link

Improve usage of Hope effects on items #356

Closed dmorcellet closed 1 year ago

dmorcellet commented 1 year ago

Hope usage in the application is in various state:

Horn of the Dwarrowdelf (1879119810): not handled (live only, does not exist in SoA Book 11)
Sticky Apple (1879305623): correctly handled as a consumable (live only, does not exist in SoA Book 11)
Glass of Aglaral (1879064049): correctly handled as a consumable (ok in live and SoA Book 11)
Bounder Shirriff's Cap (1879051516): has hope stat in live, but no hope stat in SoA Book 11
various Edhelharn Token: no hope stat, and not usable as a consumable
Hope Tomes (like "+1 Hope Tome (30 min)" 1879185892): correctly handled as a consumable.

dmorcellet commented 1 year ago

Edhelharn tokens analysis: for instance, Glorious Edhelharn Token (1879055301). Has a "Usage_SkillToExecute" property: 1879055305. 1879055305 is a skill "Star-glass". This skill has a property "Skill_AttackHook_TargetEffectList", which yields 2 effects: 1879055306 and 1879055307. The first only indicates that the second shall be applied on the whole fellowhip. The second one gives Hope for a constant duration (Effect_Duration_ConstantInterval: 1800.0 so 30min).

dmorcellet commented 1 year ago

Horn of the Dwarrowdelf is similar to hope tokens.

dmorcellet commented 1 year ago

For SoA Book11, fixed the Bounder Shirrif's Cap to that it will give +1 (properties tend to show this is a temporary effect).

dmorcellet commented 1 year ago

Activated existing code in the tools so that Edhelharn Tokens and Horn of the Dwarrowdelf are now consumables that give hope. It also creates hundreds of new consumables with various stats.

dmorcellet commented 1 year ago

No more to do on this issue. The rest will be tracked by issue #358 and issue #359.