Fix bug, sometimes program doesnt react to file changes

[LottaMe]

Current Problem: Reacts to first on_modified If result is successful, you can remove the I am done comment If result again fails, modifying doesn’t work If you save again without removing I am done comment it doesn’t re-execute, but you can still remove I am done comment to continue

[LottaMe]

Problem:

Not looking for file modification after it has already been modified. It does go to the next exercise if file is checked for # I AM NOT DONE comment.

Investigation why:

In runner these lines

try:
    filechangehandler.process.start()
        filechangehandler.process.join()


Finish when the process is terminated by on_modified. It doesn’t matter if result is successful or not, it treats the exercise as completed. The reason it is not continuing, is because of these lines in exercise.run method:

while self.check_wait():
    time.sleep(1)
        continue

Now, it is continuously checking check_wait. We have two possibilities here:

1. The file still had errors, so result.success == False. Without a new execution of the code (which is not happening right now) this will mean check_wait always returns true and pylet is stuck.
2. The file does not have errors, so result.success == True. Changes to the file won’t do anything, as the observer is already off, but check_wait will return true if check_done_comment is false. Now check_done_comment is currently not reading exercise.code, but the file at exercise.path, so it actually reads the newer version of the file and returns False if we have removed the # I AM DONE comment.

Where to go from here:

• Somehow, the runner should not continue when the process is done, but have additional checks
  • Maybe move the while loop to runner?
  • Maybe have some checks or boolean in filechangehandler?
• The # I AM DONE comment should not be read from the file every time. It will be more efficient if it just checks the code string. Once the observer isn’t canceled after the first file change, this should still work, even though now this change would break the project further.

Brainstorming without wifi:

Just copying the while loop from exercise does not really work, because: <bound method Exercise.check_wait of <exercise.Exercise object at 0x103438160>>

Maybe we can return check_wait from the process and restart it if check_wait is True?

Loop iteration is ending before the on modified is joined…

When is the process finished???

Idea:

Keep opening new processes, then close and join all of them in the end (--> how many can this support??