Lotterleben / AODVv2-Draft

0 stars 0 forks source link

updated 'cost' to 'metric' to fix issue #5 #24

Closed pv0 closed 8 years ago

pv0 commented 8 years ago

Overview: RouterClient.Cost to RouterClient.Metric, AdvRte.Metric to AdvRte.AdvMetric, AdvRte.Cost to AdvRte.Metric, Cost(L) to Metric(L), Cost(R) to Metric(R) and numerous updates to text throughout.

Lotterleben commented 8 years ago

I'm happy with the changes, in case no one objects I'd propose to merge :) @ratliffstan @charliep51

ratliffstan commented 8 years ago

No objections here... :-)

Regards, Stan

Sent from my iPhone

On Jun 30, 2016, at 10:54 AM, Lotte Steenbrink notifications@github.com wrote:

I'm happy with the changes, in case no one objects I'd propose to merge :) @ratliffstan @charliep51

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Lotterleben commented 8 years ago

@ratliffstan where are you? teleconference should've started 40 mins ago.. ;)

Lotterleben commented 8 years ago

@charliep51 , any objections? :)

charliep51 commented 8 years ago

Hello Lotte and all,

This change is O.K. with me, as long as "consistentcy" is changed to be "consistency".

There might be some places where "metric" (meaning the value of the metric) could conceivably be misconstrued as "metric type", but I don't think there are any places that are at all close to being misleading.

Anyway I think it's fine to close the issue.

Regards, Charlie P.

On 7/7/2016 10:02 AM, Lotte Steenbrink wrote:

@charliep51 https://github.com/charliep51 , any objections? :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Lotterleben/AODVv2-Draft/pull/24#issuecomment-231142321, or mute the thread https://github.com/notifications/unsubscribe/ABbdvmGtbZOcIWXQExsvW8IaII-IMkROks5qTTE0gaJpZM4I0wKu.

pv0 commented 8 years ago

Updated the typo. Thanks all.

Lotterleben commented 8 years ago

Perfect, I suppose we can merge this one then? :)

Lotterleben commented 8 years ago

(If so, I'll volunteer to do it manually to save Vicky the rebasing fuss)