search

Lotterleben / AODVv2-Draft

0 stars 0 forks source link

No Step 10 #30

Closed charliep51 closed 8 years ago

charliep51 commented 8 years ago

In section 8.2.2. RREP Reception, under step 5, there is an instruction "* If not, continue to Step 10." But there is no Step 10.

Lotterleben commented 8 years ago

Would it make sense to change that line to "If not, ignore this RREP for further processing."?

charliep51 commented 8 years ago

I think the problem had to do with text that was misinterpreted to be a pandoc directive.

Then I started wondering whether it would be possible to attach symbolic names to numbered steps (or items in a numbered list). Then I ran out of time. But anyway I reckon the problem will go away when the text is recompiled.

Lotterleben commented 8 years ago

I think this one is different than https://github.com/Lotterleben/AODVv2-Draft/issues/29 (which was fixed by https://github.com/Lotterleben/AODVv2-Draft/issues/29)... The text in this case seems more like something we forgot to change when rearranging the section at some point.

I wondered the same thing about symbolic names, it would make things so much easier! I'll ask Rick in case I see him at the Bits-n-Bites tonight.

pv0 commented 8 years ago

Looks like its meant to be step 6 instead of 10? When processing an RREP, if its for us, stop, otherwise, try to forward it.

  1. Check if the OrigPrefix matches an entry in the Router Client Set * If so, no further processing is necessary. * If not, continue to Step 10.
  2. Check if a valid (Active or Idle) or Unconfirmed LocalRoute exists to OrigPrefix * If so, continue to RREP forwarding. * If not, a Route Error message SHOULD be transmitted toward TargPrefix according to and the RREP SHOULD be discarded and not forwarded.
Lotterleben commented 8 years ago

Oh. Right! I've created a PR to fix that, I hope you don't mind :)