search

Lotterleben / AODVv2-Draft

0 stars 0 forks source link

Modifications to support multihoming by creating a new address type #32

Open charliep51 opened 8 years ago

charliep51 commented 8 years ago

Modifications to support multihoming by creating a new address type for the IP address that owns the sequence number associated with another address or address prefix.

pv0 commented 8 years ago

Happy with these changes, except for you refer to RouterClient.SeqNoRtr a few times throughout, but I think you might mean RouterClient.Multihomed? SeqNoRtr is not a field of a RouterClient (unless I missed an update?)

charliep51 commented 8 years ago

Hello Vicky,

Actually, it's the other way around.

RouterClient.Multihomed should become RouterClient.SeqNoRtr, which is nonzero only if multihomed. In that case it's the IP address of the router owning the SeqNo.

Shall I update my branch?

Regards, Charlie P.

On 8/1/2016 9:14 AM, pv0 wrote:

Happy with these changes, except for you refer to RouterClient.SeqNoRtr a few times throughout, but I think you might mean RouterClient.Multihomed? SeqNoRtr is not a field of a RouterClient (unless I missed an update?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Lotterleben/AODVv2-Draft/pull/32#issuecomment-236628535, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbdvp_ckeJwnpcFsQNkj7XqQbCvc1DMks5qbhtjgaJpZM4JHP8c.

pv0 commented 8 years ago

I dont agree. If you're configuring an address as a router client, you don't know SeqNoRtr at that point, plus I think SeqNoRtr could change depending on which route you install? I'm happy that SeqNoRtr is found on the route itself but I think the Router Client should just have the indication of whether it is multihomed.

charliep51 commented 8 years ago

Hello Vicky,

I went back through all the instances of RouterClient.Multihomed and RouterClient.SeqNoRtr, and I agree with you that it is better to convert instances of RouterClient.SeqNoRtr to be RouterClient.Multihomed, which is of type Boolean.

I'll make an update to my branch. There is at least one place where the wording has to be changed.

Regards, Charlie P.

On 8/3/2016 11:38 AM, Charlie Perkins wrote:

Hello Vicky,

Actually, it's the other way around.

RouterClient.Multihomed should become RouterClient.SeqNoRtr, which is nonzero only if multihomed. In that case it's the IP address of the router owning the SeqNo.

Shall I update my branch?

Regards, Charlie P.

On 8/1/2016 9:14 AM, pv0 wrote:

Happy with these changes, except for you refer to RouterClient.SeqNoRtr a few times throughout, but I think you might mean RouterClient.Multihomed? SeqNoRtr is not a field of a RouterClient (unless I missed an update?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Lotterleben/AODVv2-Draft/pull/32#issuecomment-236628535, or mute the thread https://github.com/notifications/unsubscribe-auth/ABbdvp_ckeJwnpcFsQNkj7XqQbCvc1DMks5qbhtjgaJpZM4JHP8c.