Lotterleben / AODVv2-Draft

0 stars 0 forks source link

RouterClient.Cost name confusing #5

Closed Lotterleben closed 8 years ago

Lotterleben commented 8 years ago

From Jiazi's review:

[Jiazi]

4.2 router client set

RouterClient.Cost The cost associated with reaching this address or address range.

Both "metric" and "cost" are used in the draft. If they are the same, please pick a term and use it consistently.

[Lotte]

Cost refers to the result of the Cost(L) function for the link to the RouterClient. Would it make more sense it this entry was called LinkCost?

[Jiazi] It's still a metric, no? Do we need to have a difference here?

charliep51 commented 8 years ago

Hello folks,

A cost metric is a good metric. I thought we had to support metrics that were not cost metrics.

However, even if we only supported cost metrics, I think that using language that is easy to understand is more important than getting rid of either the term metric or the term cost. We should keep the term metric for sure. We should keep the term cost if it is convenient and makes the document read well.

I am O.K. with defining a new function called "LinkCost" if anyone wants to do that.

Regards, Charlie P.

On 5/17/2016 7:26 AM, Lotte Steenbrink wrote:

From Jiazi's review:

[Jiazi]

4.2 router client set

    RouterClient.Cost
    The cost associated with reaching this address or address range.

Both "metric" and "cost" are used in the draft. If they are the same,
please pick a term and use it consistently.

[Lotte]

Cost refers to the result of the Cost(L) function for the link to the
RouterClient. Would it make more sense it this entry was called
LinkCost?

[Jiazi] It's still a metric, no? Do we need to have a difference here?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/Lotterleben/AODVv2-Draft/issues/5

pv0 commented 8 years ago

think this issue can be merged from the branch and closed?

Lotterleben commented 8 years ago

Agreed :)