LottieFiles / dotlottie-web

Official LottieFiles player for rendering Lottie and dotLottie animations in the web. Supports React, Vue, Svelte, SolidJS and Web Components.
https://developers.lottiefiles.com/docs/dotlottie-player/
MIT License
193 stars 11 forks source link

feat: implement solid wrapper for web #234

Closed moonlitgrace closed 5 months ago

moonlitgrace commented 5 months ago

Description

Implementation of Solid wrapper around the dotlottie-web library.

Type of change

Checklist

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 79677f98bb727a8ee983f9c04c12b6267943593d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

moonlitgrace commented 5 months ago

Hi @theashraf, porting is almost done. but these tests are failing, do you see anything odd? do I need to do anything to configure new package?

moonlitgrace commented 5 months ago

Regarding the failing tests, please ensure you're using pnpm v8 and reinstall the dependencies. I've noticed that the lock file is using pnpm v9, which might be causing dependency-related issues or version conflicts.

Yep, I forgot to enable corepack. Seems like now its fixed. cheers!