LottieFiles / dotlottie-web

Official LottieFiles player for rendering Lottie and dotLottie animations in the web. Supports React, Vue, Svelte, SolidJS and Web Components.
https://developers.lottiefiles.com/docs/dotlottie-player/
MIT License
191 stars 11 forks source link

fix(web): 🐛 Parcel build issue for DotLottieWorker #335

Closed theashraf closed 3 months ago

theashraf commented 3 months ago

Parcel build was failing in dotlottie-web version 0.30.3 due to the usage of a string literal to create a Worker, which is not supported by Parcel.

This patch modifies the worker instantiation to use a Blob instead, ensuring compatibility with Parcel.

Related issue: #333

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1e05940473167b2cee6c6d8d192a031690fa4e36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ----------------------------- | ----- | | @lottiefiles/dotlottie-web | Patch | | @lottiefiles/dotlottie-react | Patch | | @lottiefiles/dotlottie-solid | Patch | | @lottiefiles/dotlottie-svelte | Patch | | @lottiefiles/dotlottie-vue | Patch | | @lottiefiles/dotlottie-wc | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 52.49% / 30% 494 / 941
🟢 Statements 51.14% / 30% 514 / 1005
🟢 Functions 54.36% / 30% 137 / 252
🟢 Branches 55.23% / 30% 306 / 554
File CoverageNo changed files found.
Generated in workflow #1254
github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 37.48 KB (-10.48% 🔽) 750 ms (-10.48% 🔽) 223 ms (+174.06% 🔺) 972 ms
@lottiefiles/dotlottie-web WASM 386.62 KB (0%) 7.8 s (0%) 0 ms (+100% 🔺) 7.8 s
@lottiefiles/dotlottie-react 41.38 KB (-9.5% 🔽) 828 ms (-9.5% 🔽) 267 ms (+250.99% 🔺) 1.1 s
@lottiefiles/dotlottie-vue 44.54 KB (-8.98% 🔽) 891 ms (-8.98% 🔽) 300 ms (+125.5% 🔺) 1.2 s
@lottiefiles/dotlottie-wc 44.88 KB (-8.76% 🔽) 898 ms (-8.76% 🔽) 430 ms (+141.14% 🔺) 1.4 s
@lottiefiles/dotlottie-svelte 45.42 KB (-8.89% 🔽) 909 ms (-8.89% 🔽) 246 ms (+58.37% 🔺) 1.2 s
@lottiefiles/dotlottie-solid 44.39 KB (-9.06% 🔽) 888 ms (-9.06% 🔽) 364 ms (+292.71% 🔺) 1.3 s