fix: bail-out from async `createLottie` after unmount

LottieFiles / lottie-react

lottie web player as a react component

https://lottiefiles.com

MIT License

720 stars 80 forks source link

fix: bail-out from async `createLottie` after unmount #104

Open Andarist opened 2 years ago

Andarist commented 2 years ago

Description

Without this we might end up with a warning in older versions of React:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.

Type of change

[x] Patch: Bug (non-breaking change which fixes an issue)

Checklist

[x] This is something we need to do.

github-actions[bot] commented 2 years ago

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

Andarist commented 2 years ago

Bump for stale bot

github-actions[bot] commented 1 year ago

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

Andarist commented 1 year ago

Bump

github-actions[bot] commented 1 year ago

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

Andarist commented 1 year ago

Bump

github-actions[bot] commented 1 year ago

This rull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.