setSeeker frame: number | string, or just number?

LottieFiles / lottie-react

lottie web player as a react component

https://lottiefiles.com

MIT License

724 stars 80 forks source link

setSeeker frame: number | string, or just number? #111

Closed BrendanBerkley closed 1 year ago

BrendanBerkley commented 2 years ago

Overview

Mismatch between readme and code. Readme says that setSeeker can accept a number or a string (to handle percents), but the code only allows a number. (Not sure which is intended to be correct!)

Labels

[ ] Add the Type: Bug label to this issue.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

samuelOsborne commented 1 year ago

Thanks @BrendanBerkley, should be a number.