search

LottieFiles / lottie-react

lottie web player as a react component
https://lottiefiles.com
MIT License
729 stars 80 forks source link

Some lottie animations do not work on version 3.5.0 and above #129

Open rahulsuresh-git opened 1 year ago

rahulsuresh-git commented 1 year ago

Overview

We've identified that some of our lottie animations don't load when we use @lottiefiles/react-lottie-player:3.5.x This issue has prevented us from using the latest version of this package due to which we are not able to utilize the fixes that have been pushed in future versions. For example, the error event doesn't work on v3.4.9 (https://github.com/LottieFiles/lottie-react/issues/105).

This issue is clearly reproducible. I'm adding the codesandbox links below.

Consuming repo

Working version (@lottiefiles/react-lottie-player:3.4.9): https://codesandbox.io/s/un-bug-react-lottie-player-3-4-9-q6gldg?file=/src/App.js

Issue version (@lottiefiles/react-lottie-player:3.5.x): https://codesandbox.io/s/un-bug-react-lottie-player-3-5-0-hjqx4y?file=/src/App.js

The lottie JSON are available inside the codesandbox repo above.

Things we've tried:

  1. Upload the breaking JSON file to LottieFiles website where it works as intended. We tried downloading a fresh JSON from the site and loading it locally, but it doesn't work either.
  2. We've tried switching to React 17 but the issue still happens irrespective of React version.
  3. Tried multiple other lottie react packages like https://github.com/airbnb/lottie-web, including native implementation using https://github.com/LottieFiles/lottie-player but faced the same issue on latest versions.

We would appreciate if this is resolved at the earliest. Let me know if you require further information :)

samuelOsborne commented 1 year ago

Hi @rahulsuresh-git This issue would be best posted on

https://github.com/airbnb/lottie-web

as thats what we're wrapping in this react player.

rahulsuresh-git commented 1 year ago

Hey @samuelOsborne, thanks for the reply. I thought that all the other packages used and wrapped over this package, since this is the package provided by the company that created Lottie.

Is the airbnb package the official package for react implementation of Lottie?

P.S: I'm curious on why this isn't the official package? :)

samuelOsborne commented 1 year ago

@rahulsuresh-git its the other way round :) The airbnb package is the official implementation of Lottie. This repository is a react wrapper on top of it with extra helpers

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.