search

LottieFiles / lottie-react

lottie web player as a react component
https://lottiefiles.com
MIT License
720 stars 80 forks source link

Support for React 16.8.0+ ? #77

Closed 0x3c closed 2 years ago

0x3c commented 2 years ago 
npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   react@"^16.13.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from @lottiefiles/react-lottie-player@3.4.2
npm ERR! node_modules/@lottiefiles/react-lottie-player
npm ERR!   @lottiefiles/react-lottie-player@"*" from the root project
samuelOsborne commented 2 years ago

Hi @sosamuel I can't reproduce this error locally or on code sand box. Could you possible share your package.json file ?

https://codesandbox.io/s/flamboyant-shamir-wzjqpq?file=/package.json

krotovic commented 2 years ago

I may have found similar issue... I have in dependencies react@^17.0.2 and @lottiefiles/react-lottie-player@"^3.4.2 but npm install --no-lockfile crashes with

npm ERR! While resolving: web_v2@6.1.0
npm ERR! Found: @lottiefiles/react-lottie-player@3.1.2
npm ERR! node_modules/@lottiefiles/react-lottie-player
npm ERR!   @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@17.0.2
npm ERR! node_modules/react
npm ERR!   peer react@"^17.0.2" from @lottiefiles/react-lottie-player@3.4.2
npm ERR!   node_modules/@lottiefiles/react-lottie-player
npm ERR!     @lottiefiles/react-lottie-player@"^3.4.2" from the root project
npm ERR!

I'm not sure whose issue it is, npm or yours.

RonaldDBezerra commented 2 years ago

hello friend, I have the same problem with my lottie, it doesn't work for version 18.0.0 of react. Does anyone know if there is an update that fixes this?

samuelOsborne commented 2 years ago

Hey everyone, please try out version v3.4.5

https://www.npmjs.com/package/@lottiefiles/react-lottie-player/v/3.4.5

ANIRUDHADITHYA commented 2 years ago

animation loads and display twice in react 18

samuelOsborne commented 2 years ago

@ANIRUDHADITHYA I can't reproduce this issue

https://codesandbox.io/s/react-18-lottie-player-uegtql

ANIRUDHADITHYA commented 2 years ago

@samuelOsborne I have made changes there, kindly check https://codesandbox.io/s/react-18-lottie-player-uegtql

in style using "width=100%" makes the component double

samuelOsborne commented 2 years ago

@ANIRUDHADITHYA You need to send my the link to your forked codesandbox.

I put width 100% on mine and couldn't reproduce: https://codesandbox.io/s/react-18-lottie-player-uegtql?file=/src/App.js

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.