search

Lou8is / docs.nestjs.fr

MIT License
6 stars 7 forks source link

chore(fr): Updates small changes up to EN dbf366a #186

Closed pacyL2K19 closed 10 months ago

pacyL2K19 commented 10 months ago

PR Checklist

Merci de vérifier que vous suivez bien les recommandations suivantes :

Types de PR

Quel est l'objet de cette PR :

Liens

163

Autres détails (optionnel)

netlify[bot] commented 10 months ago

Deploy Preview for docs-nestjs-fr ready!

Name Link
Latest commit ad8d17c19a20bcb4d35833353ae8f0505e8f9528
Latest deploy log https://app.netlify.com/sites/docs-nestjs-fr/deploys/655bb8916f618400080dbce0
Deploy Preview https://deploy-preview-186--docs-nestjs-fr.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pacyL2K19 commented 10 months ago

@Lou8is Kindly have a look

Lou8is commented 10 months ago

The build step seems to be broken due to an error on the updated file, I suggest you test it locally to correct the error.

If you're stuck I'll be happy to help :)

pacyL2K19 commented 10 months ago

Hi, translation looks good to me!

I noted a few errors to correct before approval (mostly formatting using ** or `` ).

Thanks for your time!

Thank you for the review I am on it

pacyL2K19 commented 10 months ago

Hi, translation looks good to me! I noted a few errors to correct before approval (mostly formatting using ** or `` ). Thanks for your time!

Thank you for the review I am on it

@Lou8is I have fixed the formatting issues, thank you for catching them About the build step, I only updated the md file and locally the build runs successfully Can you help me check this? Screenshot 2023-11-20 at 21 47 50

Lou8is commented 10 months ago

The updated file was building OK, it might have been the missing ** for Hint macros that prevented it before. Your updates should be live in a few minute, thanks!