Closed 12rambau closed 12 months ago
From what I understand, as next_cleanup_time is set rior to the while loop, now will always be at least 5 steps afterward right ? To me this condition: if proxy and now >= next_cleanup_time: is redundant. What do you think ?
next_cleanup_time
now
if proxy and now >= next_cleanup_time:
https://github.com/Louis-Dreyfus-Company/geeservermap/blob/e0bc8a96f6d68f0b42dc5163d129bc6517f87396/geeservermap/async_jobs.py#L97C18-L97C18
My mistake, the value of next_cleanup_time is reevaluated at the end of the loop.
From what I understand, as
next_cleanup_time
is set rior to the while loop,now
will always be at least 5 steps afterward right ? To me this condition:if proxy and now >= next_cleanup_time:
is redundant. What do you think ?https://github.com/Louis-Dreyfus-Company/geeservermap/blob/e0bc8a96f6d68f0b42dc5163d129bc6517f87396/geeservermap/async_jobs.py#L97C18-L97C18