search

LouisBarranqueiro / reapop

:postbox: A simple and customizable React notifications system
https://louisbarranqueiro.github.io/reapop
MIT License
1.55k stars 78 forks source link

String IDs are prohibited #14

Closed ckald closed 7 years ago

ckald commented 7 years ago

Hi again! Setting IDs works exactly as I needed it to!

But I found out that propTypes prohibit setting string IDs. For the time being I'm just hashing strings to ints, but this would be a minuscule change in the code

LouisBarranqueiro commented 7 years ago

yes, could you PR and add tests, please? :)

LouisBarranqueiro commented 7 years ago

Reapop v1.0.0 is released - Read breaking changes before update :)

ckald commented 7 years ago

Thanks! I haven't gotten around to do this