Specify Message Tag - Githubissues

LouisBarranqueiro / reapop

:postbox: A simple and customizable React notifications system

https://louisbarranqueiro.github.io/reapop

MIT License

1.55k stars 78 forks source link

Specify Message Tag #502

Closed NeXTs closed 2 years ago

NeXTs commented 2 years ago

Description

I want to be able to specify tag of Message component. I need to do it div instead of p

Explanation / motivation

Because I inserted React component inside Message and receive a warning Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

Additional information

[ ] I can implement this feature/improvement

NeXTs commented 2 years ago

@LouisBarranqueiro do you need it to be p? What downsides if it will be changed to div by default?

LouisBarranqueiro commented 2 years ago

👋 , I don't remember exactly why I put a p instead of div I guess because I didn't think about your use case. Tested with a div and it looks the same. gonna make the change.