search

LouisCAD / Splitties

A collection of hand-crafted extensions for your Kotlin projects.
https://splitties.louiscad.com
Apache License 2.0
2.53k stars 159 forks source link

Update RecyclerView.fixedSize extension description #209

Closed mareklangiewicz closed 5 years ago

mareklangiewicz commented 5 years ago

It's not really about items having the same size

LouisCAD commented 5 years ago

The description you put looks more like the original documentation, which I've seen people struggle a little to understand.

The current description I put intentionally has an example and I find it explains sufficiently well that all the items must keep the same size as per the adapter content for this optimization to be able to be turned on safely.

mareklangiewicz commented 5 years ago

Ok, I just thought (based on your description) I shouldn't set it to true if first item in my RecyclerView is bigger than the second. Then checked in google docs, that I still can set it to true (as long as changing the content of an item doesn't change the size of it). But the difference is subtle, and it's true that in your example user can set it to true, so I don't insist to change it :-)