plugins.id("de.fayard.refreshVersions").version("0.7.0")

[jmfayard]

The plugin is now released, under a brand new name!

https://plugins.gradle.org/plugin/de.fayard.refreshVersions

See Long term plan: focus on refreshVersions #104

[LouisCAD]

Also, note that alphabetical order is weirdly split in non plugin versions. If you can, take a look after the version overwriting issue is resolved. That issue is not blocking though.

[jmfayard]

Once it's done, if you try to test dependency refreshing by downgrading kotlinx.coroutines version to 1.3.1 and run the refreshVersions gradle task again, you'll see that it doesn't advertise the new version in a comment as usual but directly overwrites it with latest version. This bug needs to be fixed before I can merge this PR.

I can reproduce this bug. Nasty indeed. I will fix it

[jmfayard]

Also, note that alphabetical order is weirdly split in non plugin versions.

@LouisCAD the order is like this:

• plugins, sorted, starting at plugin.com.github.ben-manes.versions
• groups, sorted, starting at version.androidx.arch.core
• fqdn, sorted, starting at version.androidx.annotation..annotation
• modules, sorted, starting at version.aapt2

[jmfayard]

@LouisCAD the Gradle Sync is still failing by default, I think it's because those are not resolved by default. Can you have a look?

https://scans.gradle.com/s/gjexntaxltq2k/dependencies?toggled=W1swXSxbMCw4XV0

[jmfayard]

@LouisCAD The build had most dependencies using Kotlin 1.3.50, but some other using 1.3.41. I aligned all dependencies to use Kotlin 1.3.50. Running again :refreshVersions produces then as expected version.org.jetbrains.kotlin=1.3.50

The Gradle sync still fails, but now because of this bug.

https://stackoverflow.com/questions/58216418/gradle-sync-failed-unsupported-method-kotlinplatformcontainer-supports

[jmfayard]

Yes!

Le lun. 14 oct. 2019 à 17:31, Louis CAD notifications@github.com a écrit :

@LouisCAD approved this pull request.

Gradle sync is working correctly, and it looks good to me. Should I merge it now?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LouisCAD/Splitties/pull/215?email_source=notifications&email_token=AADQFSAJQEKULQFCDSYT6Q3QOSGGTA5CNFSM4I7PA62KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCH3L5NQ#pullrequestreview-301383350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQFSGZ2TLZVFEZWLKHEFDQOSGGTANCNFSM4I7PA62A .