Do not use unnamed namespace in header

LouisCharlesC / safe

Header only read/write wrapper for mutexes and locks.

MIT License

147 stars 11 forks source link

Do not use unnamed namespace in header #16

Closed travnick closed 4 years ago

travnick commented 4 years ago

https://github.com/LouisCharlesC/safe/blob/faebc6c2f45c2b568bc83926b33386d3f7aacd35/include/safe/safe.h#L21

reason: https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL59-CPP.+Do+not+define+an+unnamed+namespace+in+a+header+file

LouisCharlesC commented 4 years ago

Uh oh. Thanks for the tip! I'm working on and off on a huge commit that will pretty much touch every line of code in this repo. This fix will be included in there!

LouisCharlesC commented 4 years ago

There, you have it! Thanks again for the input.

travnick commented 4 years ago

I'm happy to help!