search

LouisCharlesC / safe

Header only read/write wrapper to combine mutexes with locks.
MIT License
149 stars 11 forks source link

[Debian] Please change dependency import for .deb packaging #27

Closed Robert-Ernst closed 1 year ago

Robert-Ernst commented 1 year ago

Hello,

you added a remote code download for your testing package doctest.

According to the Debian Free Software Guidelines this restricts us to update your application from v1.0.1 to v1.1.0. It wouldn't be in good spirit to the Desert Island Test which is a popular way to assert Free Software.

If you are still interested to be updated within the Debian ecosystem please consider checking for a local doctest then download it instead of FetchContent in your tests/CMakeLists.txt file so your application is again within Debian policy limits.

You can reply me here to trigger the update process again.

Greets Ernst

ahoarau commented 1 year ago

What about just setting the BUILD_TESTING option at OFF by default ?

Tests are only for internal purpose

pabs3 commented 1 year ago

I submitted a patch in #28 that will use a locally installed doctest when it is present (for offline builds like Debian's) and download the doctest git repo when it isn't. There are also options to force offline mode and to force online mode.

LouisCharlesC commented 1 year ago

Sorry for taking so much time to address this. I don't know CMake well and I thought your solution was too complicated for me. But seeing that I put absolutely no time on it for a whole month, accepting the PR felt like the right thing to do. Thanks for the help, Louis-Charles

pabs3 commented 1 year ago

Thanks for accepting the patch. I don't think there is a simpler way to do it unfortunately. Perhaps some day CMake itself will have a way.

-- bye, pabs

https://bonedaddy.net/pabs3/