search

LouisDesdoigts / dLux

Differentiable optical models as parameterised neural networks in Jax using Zodiax
https://louisdesdoigts.github.io/dLux/
BSD 3-Clause "New" or "Revised" License
43 stars 6 forks source link

Investiage usage of 'preferred units' #238

Closed LouisDesdoigts closed 9 months ago

LouisDesdoigts commented 11 months ago

After a great chat with @brandondube about preferred units, it could be a good idea to migrate the default units away from SI. IIRC, as implemented in Prysm currently this is mm for pupil planes and microns for focal planes.

The overall idea is to keep units as close to unity as possible to circumvent loss of precision from either very large or small floating point values.

This issue is simply to track the progress of the idea and annoy Brandon with questions ☺️.

LouisDesdoigts commented 9 months ago

Decided against this, in favour of jpu units in the future