search

LouisDesdoigts / dLux

Differentiable optical models as parameterised neural networks in Jax using Zodiax
https://louisdesdoigts.github.io/dLux/
BSD 3-Clause "New" or "Revised" License
43 stars 6 forks source link

pixel_fn rewrite within nd_coords #261

Open maxecharles opened 8 months ago

maxecharles commented 8 months ago

PR to track progress. See #260

maxecharles commented 8 months ago

@LouisDesdoigts do u still wanna merge it hehe

LouisDesdoigts commented 8 months ago

Yah keen for the changes. Although small optimisation, rather than start and end, just calculate the end value as 'k' and linspace from -k, k

maxecharles commented 8 months ago

Yah keen for the changes. Although small optimisation, rather than start and end, just calculate the end value as 'k' and linspace from -k, k

This won't actually work if offset is nonzero as it's not symmetric about zero.

LouisDesdoigts commented 8 months ago

Ah yeah of course, this is perfect then. Probs wont merge this till I get some time to actually do some proper work on dLux. This isn't holding up anything youre doing right?

maxecharles commented 8 months ago

nup you're all good