Remove all calls to `.normalise` when calculating things.

LouisDesdoigts / dLux

Differentiable optical models as parameterised neural networks in Jax using Zodiax

https://louisdesdoigts.github.io/dLux/

BSD 3-Clause "New" or "Revised" License

52 stars 6 forks source link

Remove all calls to `.normalise` when calculating things. #265

Open LouisDesdoigts opened 12 months ago

LouisDesdoigts commented 12 months ago

This has shown to interfere with things like the FIM and gradients which is highly undesirable. Users should perform their own post-update step normalisation.

This could also precipitate the removal of these methods all together!