nus-se-script
commented
3 years ago Team's Response
Thanks for this bug report.
This bug has been accepted because it is a valid flaw.
However, I've downgraded the severity to low as most households, whom this product is targeted towards:
- would not be editing their text file unless they knew how to use it.
Hence, most users are unlikely to face this problem, and it wouldn't hinder normal usage in the slightest. Furthermore, if the user needed to make the app correct, they could remove the space that they inserted in the saved file. Hope you can accept this severity.
Items for the Tester to Verify
:question: Issue severity
Team chose [severity.Low]
Originally [severity.High]
- [x] I disagree
Reason for disagreement: Thank you for the response! Although it might not be as likely, I think overlooking such a problem could be damaging. Typos are more often than expected. A study suggested that it is harder for typers to identify their own errors (https://www.wired.com/2014/08/wuwt-typos/). Therefore, such minor typos, ie. adding extra space, might not be as easily identifiable. And an error at the start of the program might not be well expected by users who expected a proper savefile.
Moreover, stating that target users would not edit the text file might not be as accurate, as the files are for users to edit (Hence, why it is human editable). And stating a warning in the user guide not to tamper with files is still not an excuse for developers not to catch and filter any file-related errors, ie. data corruption.
This was further emphasized in detail by the prof in this issue: https://github.com/nus-cs2113-AY2122S1/forum/issues/144
I decided to mark this bug with high severity as it prevented users from starting the program at all and no filter was implemented for the corrupted data caused by a minor typo, and no fix was offered by the program. Hence, could cause the product to almost be unusable for users.
As a user, if I edit manually from the file and insert an extra space, in this case, before "Qty", this saved data will not be filtered out and prevents the program from running, as an exception is thrown.
