search

LouisLouis19 / pe

0 stars 0 forks source link

Save file not filtered when name is the parser itself (|) #5

Open LouisLouis19 opened 3 years ago

LouisLouis19 commented 3 years ago

When I change the name of my food to "|", an exception is thrown at the start of the program. Preventing the program to start. Perhaps a filter could be implemented for this. Screenshot 2021-11-12 at 4.30.16 PM.png

Screenshot 2021-11-12 at 4.31.01 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for this bug report. However, Fridget can actually to allow | from savedShop.txt.

image.png

The actual issue is that there is no space in between | and |. Thanks for letting us know.

We've chosen to reduce the severity of this bug report to Low for two main reasons:

image.png

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to start when random values are inserted in the Shopsaved file

Random values are added, as a result of my confusion on how to add items to the shoplist Screenshot 2021-11-12 at 4.48.43 PM.png Screenshot 2021-11-12 at 4.49.12 PM.png

[original: nus-cs2113-AY2122S1/pe-interim#2923] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This bug has been accepted as a valid complaint. However, the issue is not because of the random values inserted. In fact, Fridget does manage to successfully parse the values as seen in the image below.

image.png

The actual issue is that there is no space in between 12121 and |. Thanks for letting us know.

We've chosen to reduce the severity of this bug report to Low for two main reasons:

image.png

  • Most users would not tamper with the txt files anyway. If they decided to do so, they would be skilled enough to edit it correctly.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Thank you for the response! Upon your explanation of the lack of spacing, I now understand why the values I inserted in the text file caused the program to crash at the start. Initially, upon witnessing a crash in the program, I tried to fix the text file but to no avail. Perhaps, this is because I am not skilled enough to edit or fix the file correctly and I was not aware of your specific data saving technique in the text file.

Moreover, stating that "Most users would not tamper with the txt files anyway" is an understatement, as the files are for users to edit (Hence, why it is human editable). And stating a warning in the user guide not to tamper with files is still not an excuse for developers not to catch and filter any file-related errors, ie. data corruption.

This was further emphasized in detail by the prof in this issue: https://github.com/nus-cs2113-AY2122S1/forum/issues/144

I decided to mark this bug with medium severity as it prevented users from starting the program at all and no filter was implemented for the corrupted data. Hence, causing a major inconvenience to users.