MapMyFitness Callback Issue?

[breethomas]

@jayzes @mikepack @LouisaBarrett

Jay/Mike. Not sure what we messed up...but we can't get past the MMF auth page. Something goofy in the callback I think.... Here is detailed list of what's happening:

• Can successfully hit homepage/login
• Can successfully hit MMF auth page (https://www.mapmyfitness.com/v7.0/oauth2/authorize/confirm)
• Once clicking authorize from MMF auth-page, it appears to break on the way back. The error I get is "undefined method `strip' for nil:NilClass", which is happening in this file: block in initialize_http_header/Users/breethomas/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http/header.rb
• Specifically in this block:

 def initialize_http_header(initheader)
    @header = {}
    return unless initheader
    initheader.each do |key, value|
      warn "net/http: warning: duplicated HTTP header: #{key}" if key?(key) and $VERBOSE
      @header[key.downcase] = [value.strip]
    end
  end

• We are using better errors, and here are the values of that initheader and key/value:

  initheader => {"Api-key"=>nil, "User-Agent"=>"Faraday v0.9.0", "Content-Type"=>"application/x-www-form-urlencoded", "accept-encoding"=>"gzip;q=1.0,deflate;q=0.6,identity;q=0.3"} key => "Api-key" value => nil

• I don't know enough about that initheader hash, or why/what it is being sent back (or rather not being sent back with "Api-key") to know what things to try and fix it.
• I sat w/ Casimir for like 15 minutes and we checked the Environment stuff, which all seems to be in order. We're using the dotenv-rails gem, and my .env file for export is correct w/ the MMF api key and secret. It can find it when we are in rails console.
• I also honestly can't think of anything we've changed recently that would have touched anything with environments....

[jayzes]

Interesting. Was it broken locally or when you deployed?

[unrealities]

I was getting this issue locally when I was just hacking around omniauth.rb and put my api_key and api_secret directly in the initializer instead of using environment variables. When I updated my .bash_profile to export ENV['MMF_API_KEY'] and ENV['MMF_API_SECRET'] I was able to get the callback to complete successfully.

I noticed this note in the omniauth-mapmyfitness-oauth2 readme that got me going:

NOTE: The ENV['MMF_API_KEY'] is unsed in an unusual place in this strategy. It must be defined for the library to work.

Hopefully this is just how you're setting your environment variables locally or when you deploy.

[LouisaBarrett]

@unrealities Hi Tom!

We are using the gem dotenv-rails for exporting the key/secret, however, we inadvertently moved that gem lower in the gem file, below the omniauth-mapmyfitness-oauth2 gem, so it was breaking. Whoops!

Thanks for all your feedback, we were excited to hear your thoughts! :) -L

[unrealities]

@LouisaBarrett makes sense. Glad you got it figured out!