search

LouiseMcMahon / nodebb-plugin-s3-uploads

A plugin for NodeBB to take file uploads and store them on S3
MIT License
17 stars 23 forks source link

Update aws sdk version and signature version #23

Open weatherstar opened 7 years ago

LouiseMcMahon commented 7 years ago

Can you give me a bit more info on your goal with this? is it just to update it or does this fix something?

On 30 March 2017 at 07:05, Weatherstar notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/LouiseMcMahon/nodebb-plugin-s3-uploads/pull/23 Commit Summary

    1. update aws sdk

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LouiseMcMahon/nodebb-plugin-s3-uploads/pull/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AULhNdvYej7Dy9zift2aIw0AKUyrNjqDks5rq0ZGgaJpZM4Mt5y2 .

weatherstar commented 7 years ago

@LouiseMcMahon I'm sorry not to explain clearly. When using this plugin(with nodeBB 1.4.5), I get the following error:

AWS::S3::Errors::InvalidRequest The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256

I have checked some information said that I should use signature_version: 'v4' in aws-sdk like var s3 = new AWS.S3({ signatureVersion: 'v4' }); So I add it to the settings and then upgraded the version of aws-skd and it worked. That's the reason I created this pull request : )