search

Louisvdw / dbus-serialbattery

Battery Monitor driver for serial battery in VenusOS GX systems
MIT License
530 stars 164 forks source link

Battery capacity reduction for C rate computation when a cell goes in to protection. #1055

Closed AlexdeKairos closed 4 months ago

AlexdeKairos commented 4 months ago

Is your feature request related to a problem? Please describe.

Following the CCL and DCL going to 0 in the event a unit goes to protection (Multi battery setup) one additional thing should be taken in to consideration. We use C rate units for many computations. In the event of a battery going in to protection, its capacity should not be taken for C rate computations. May be going to 0 if discharge and charge goes to 0 or may be on charging, just for computations, its value removed from computations and same for discharging. If not, although its an optimization of the charging and discharging, the total C rate will be related to all units connected and not the "operative" ones. It's not critical but will optimize charging one step forward.

Describe the solution you'd like

Adjust total capacity to the available battery units. The operational ones without protections active.

Describe alternatives you've considered

No response

Additional context

No response

mr-manuel commented 4 months ago
  1. If I understood correctly, you want that the total shown capacity is changed, when a battery does not allow discharging anymore?
  2. For what would this be useful?
  3. Why are you not using the available capacity?

For a single battery I would not do that anyway. For a multi battery setup, you have to open an issue in the repository of the aggregator you are using.

AlexdeKairos commented 4 months ago

Hi Manuel, That's not actually the pretended functionality but close...

But you are right that may be is the battery agregator functionality.

Please close this feature request...

El dom, 12 may 2024, 9:37, Manuel @.***> escribió:

  1. If I understood correctly, you want that the total shown capacity is changed, when a battery does not allow discharging anymore?
  2. For what would this be useful?
  3. Why are you not using the available capacity?

For a single battery I would not do that anyway. For a multi battery setup, you have to open an issue in the repository of the aggregator you are using.

— Reply to this email directly, view it on GitHub https://github.com/Louisvdw/dbus-serialbattery/issues/1055#issuecomment-2106152149, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFPOLCQDXCE2CNUS6YRQREDZB4L5PAVCNFSM6AAAAABHRXGB4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGE2TEMJUHE . You are receiving this because you authored the thread.Message ID: @.***>

mr-manuel commented 4 months ago

Ok. Only for clarification. Then you meant that, if the available capacity is not usable it should be 0?