added support for JK BMS with Partnumber PBxxxxx

Louisvdw / dbus-serialbattery

Battery Monitor driver for serial battery in VenusOS GX systems

MIT License

492 stars 157 forks source link

added support for JK BMS with Partnumber PBxxxxx #1087

Closed KoljaWindeler closed 5 days ago

KoljaWindeler commented 5 days ago

This pull request adds support for the JK BMS that is used in the EEL boxes. Their Model Number start with PBxxxxx

I've tested this implimentation for about a week and it looks like it is running fine. It misses propper CRC checking, but I was unable to find out the CRC algorithm in use. There is only one non-zero byte at the end of the message and it is not following any of the common CRC algorithms. So for now I rely on a fixed length and a header detection.

Thanks, JKW

mr-manuel commented 5 days ago

Thank you for contributing to this driver. As discussed please open the PR in my repository. Alternatively I can close this PR and add it manually.

Please fill also out this table: https://github.com/mr-manuel/venus-os_dbus-serialbattery/blob/docusaurus/docs/docs/general/features.md#bms-feature-comparison

KoljaWindeler commented 5 days ago

ha, different maintainer .. now i get it .. sorry didn't realized the change

KoljaWindeler commented 5 days ago

i hope it still works the same as I'm not sure which version I was running on my dev environment edit: developed with this version utils.py:DRIVER_VERSION = "1.2.20240408"